[osol-discuss] [ufs-discuss] PANIC! mounting cdrom slice on b78

[Scott Rotondo]

Joerg Schilling wrote:
> Scott Rotondo <scott.rotondo at sun.com> wrote:
> 
>> Joerg Schilling wrote:
>>>
>>> Does it help to intialize the pointers to NULL?
>>>
>> Sure. This code
>>
>>      943 	if (fsp)
>>      944 		kmem_free(fsp, sizeof (*fsp));
>>      945 	if (svp)
>>      946 		kmem_free(svp, sizeof (*svp));
>>      947 	if (jvp)
>>      948 		kmem_free(jvp, sizeof (*jvp));
>>
>> will behave very differently if those pointers are NULL rather than 
>> uninitialized.
> 
> ????
> 
> I was interested in a useful reply for the OP case....

Sorry, I don't know what you're asking.

> 
> Did you run a test with the original filesystem, or what do you like to tell us 
> here?

I didn't test anything. I was just pointing out, based on simple 
examination of the source code, that line 944 is sure to panic if fsp 
contains random bits, but if it's set to NULL then line 943 will prevent 
944 from executing at all.

	Scott