[pkg-discuss] CR request for bug 2693

[Shawn Walker]

Dan Price wrote:
> On Fri 01 Aug 2008 at 02:10PM, Brock Pytlik wrote:
>> Danek Duvall wrote:
>>> On Wed, Jul 30, 2008 at 01:24:43PM -0700, Brock Pytlik wrote:
>>>
>>>   
>>>>>> Stephen had mentioned that we were still printing out the catalog on
>>>>>> startup, as we acquired it.  I couldn't find the code that was doing 
>>>>>> that.  Did you find it, or confirm that it isn't doing that anymore
>>>>>> and that Stephen is just smoking something?
>>>>>>         
>>>>>  Ah, that's line 351 in catalog.py.  Doesn't have to be this wad.  In
>>>>>  fact, we shouldn't generally run into it, so the indication that
>>>>>  something's amiss (even if slightly) may not be the worst thing in the
>>>>>  world.
>>>>>       
>>>> So, should I leave the line in that case?
>>>>     
>>> Yeah.  Let Stephen file the bug to remove it if he wants to do so.  He
>>> should have an answer for how much information we need to provide in the
>>> case where we now print out all the fmris.
>>>
>>> Danek
>>>   
>> Ok, new CR at:
>> http://cr.opensolaris.org/~bpytlik/ips-2693-v3/
>>
>> It's fixed the issues Danek raised and left the print line in.
>>
>> Comments anyone?
> 
> Looks fine to me.  No new comments.

Same here.


-- 
Shawn Walker