[pkg-discuss] code review request: 2272 pkgrecv should uncompress by default

Brad Hall bhall at bgh.hallgroup.org
Wed Jul 2 21:57:49 PDT 2008


On Thu, Jul 03, 2008 at 10:23:08AM +0530, Venky wrote:
> On Wed, Jul 02, 2008 at 09:36:37PM -0700, Brad Hall wrote:
> > 2272 pkgrecv should uncompress by default
> > 
> > Link to CR: http://cr.opensolaris.org/~bgh/bug-2272/
> 
> Line 129:
>     This could just be a:
>         outfile = open(fpath, "wb")
> 
>     Or you could lose the "fpath" assignment in the previous line
>     and do the interpolation in-place.
> 
> The rest looks good.
> 

Good point, fixed, and updated webrev.

Thanks!
-Brad



More information about the pkg-discuss mailing list