[pkg-discuss] Code review request for opensolaris packaging bug #4502

[Rich Burridge]

Hi all,

I'm looking for a review of the fix for bug #4502:

  http://defect.opensolaris.org/bz/show_bug.cgi?id=4502
  Missing package dependency for SUNWgnome-time-slider

Webrev is at:

  http://cr.opensolaris.org/~richb/pkg-4502-v1/

Tested by creating a local repository with the SUNWgnome-time-slider
in it, then installing it on my local machine (running build 101a)
and checking the dependencies:

  $ pfexec pkg set-authority -P -O http://stard.sfbay.sun.com:24502 bug-4502
  $ pfexec pkg refresh
 
  $ pfexec pkg install SUNWgnome-time-slider
  DOWNLOAD                                    PKGS       FILES     XFER (MB)
  Completed                                    1/1         2/2     0.00/0.00

  PHASE                                        ACTIONS
  Removal Phase                                    1/1
  Install Phase                                    4/4
  Update Phase                                     3/3
  PHASE                                          ITEMS
  Reading Existing Index                           9/9
  Indexing Packages                                1/1

  $ pfexec pkg set-authority -P opensolaris.org
  $ pfexec pkg unset-authority bug-4502
 
  $ pfexec pkg contents -m SUNWgnome-time-slider | grep "^depend"
  depend fmri=SUNWzfs-auto-snapshot at 0.5.11-0.101 type=require
  depend fmri=SUNWgksu at 0.5.11-0.101 type=require
  depend fmri=SUNWgnome-python-libs at 0.5.11-0.101 type=require
  depend fmri=SUNWPython at 2.4.4-0.101 type=require

Thanks.