[pkg-discuss] Code review: bug #8394 - image-update without a --be-name fails.

[Rich Burridge]

And Shawn spotted another couple of problems,
so here's a third (and hopefully final) webrev:

  http://cr.opensolaris.org/~richb/pkg-8394-v3/

Thanks.


-------- Original Message --------
Subject: 	Re: [pkg-discuss] Code review: bug #8394 - image-update 
without a --be-name fails.]
Date: 	Thu, 23 Apr 2009 17:23:45 -0700
From: 	Rich Burridge <Rich.Burridge at Sun.COM>
To: 	pkg discuss <pkg-discuss at opensolaris.org>



Shawn spotted another call to check_be_name() in bootenv.py
that I'd missed, that needed to be adjusted not to expect a
return value and raise and exception.

New webrev at:

 http://cr.opensolaris.org/~richb/pkg-8394-v2/

Thanks.


-------- Original Message --------
Subject: 	Code review: bug #8394 - image-update without a --be-name fails.
Date: 	Thu, 23 Apr 2009 17:05:00 -0700
From: 	Rich Burridge <rich.burridge at sun.com>
To: 	pkg discuss <pkg-discuss at opensolaris.org>



Hi all,

Looking for a quick code review for the stupid mistake I made this
morning in the "fix" for bug #8048.

This is hopefully now fixed with these changes for bug #8394:

http://defect.opensolaris.org/bz/show_bug.cgi?id=8394
image-update without a --be-name fails.

Webrev is at:

http://cr.opensolaris.org/~richb/pkg-8394-v1/

Thanks to Shawn for finding this.



_______________________________________________
pkg-discuss mailing list
pkg-discuss at opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss