[pkg-discuss] [REVIEW] Fix for bug 5603

[Danek Duvall]

On Tue, Jan 06, 2009 at 08:43:46PM -0600, Shawn Walker wrote:

> Danek Duvall wrote:
>> On Tue, Jan 06, 2009 at 07:53:46PM -0600, Shawn Walker wrote:
>>
>>> That might be best with a few twists; I just realised we re-create the 
>>> catalog file every time we add an fmri, which is atrocious anyway.
>>
>> Maybe, but it's atomic.  If you write the catalog file directly, there's a
>> window where it may be served improperly formatted.  Not to mention if you
>> accidentally have two depots running in the same repo.
>
> Right, I know why we did it, but it screams slow.
>
> I wonder just how much it affects publishing performance...

Please prefer correctness over performance.  If you don't know how much it
affects performance, don't make the change until you've measured it.

Besides, isn't this one of the things we could use the updatelog for?
Seems like an excellent opportunity to get the two tied together a bit
better.

Danek