[pkg-discuss] CR for 5665 and 4960

[Padraig O'Briain]

Looks good to me.

Padraig

On 01/07/09 11:36, Michal Pryc wrote:
> New webrev:
> http://cr.opensolaris.org/~migi/5665_5663_4960_v2/
>
> Changes compared to the previous webrev:
> - line 22 - Changed copyright from 2008 to 2009
> - 1916 - Caching TransportFailures instead of all exceptions
> - no line as this was new code block - Removed commented out lines
> - After conversation with xDesign:
>    - 1098 - If there is no summary, then the summary is "None"
>    - 1090, 1093 - If there is no classification, then we are showing "None"
>    - 1106-1109 - Version contains the branch and release
>    Also if the package was installed in the previous version we were 
> showing information about the newest package. Currently we are showing 
> the installed package information. If the package is not installed then 
> we are showing the newest available (this was discussed with xDesign).
>
> best
> Michal
>
> Padraig O'Briain wrote:
>   
>> Some comments:
>>
>> 1) Is the latest version and installed version correct?
>>
>> On my system I have packages which are installed which have updates. The
>> installed version and the latest version are reported as the same which
>> does not look correct.
>>
>> 2) For some packages the Summary and Category are empty. An example is
>> FSWxorg-fonts. Is this outside your control?
>>
>> 3) In the webrev in _show_package_info there are some lines added which
>> are commented out. Should these lines be removed?
>>
>> 4) Is the change near line 1900 to fix 4960.
>>
>> Padraig
>>
>> On 01/05/09 15:45, Michal Pryc wrote:
>>     
>>> Hello and HAPPY NEW YEAR!
>>>
>>> Here is my first CR in 2009:
>>>
>>> http://cr.opensolaris.org/~migi/5665_4960_v1/
>>>
>>> Bugs: 5665 and 4960
>>>
>>> best
>>> Michal Pryc
>>>       
>
> _______________________________________________
> pkg-discuss mailing list
> pkg-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.opensolaris.org/pipermail/pkg-discuss/attachments/20090108/f4bab48c/attachment.html>