[pkg-discuss] Code review: 12485 Webinstall sub dialogs not getting focus

[Padraig O'Briain]

Looks good to me.

Padraig

On 11/05/09 11:55, jmr wrote:
> Thanks - removed __set_modal_and_transient().
>
> http://cr.opensolaris.org/~jmr/pm_12458_webinstall_focus_5Nov_1150am/
> 12485 Webinstall sub dialogs not getting focus
>
> JR
>
> Padraig O'Briain wrote:
>> Note that the bug number is 12458 and not 12485.
>>
>> In repository.py you should remove __set_modal_and_transient as it is 
>> no longer used.
>> Otherwise looks good to me.
>>
>> Padraig
>>
>> On 11/04/09 17:57, jmr wrote:
>>> Joanmarie Diggs wrote:
>>>> On Wed, 2009-11-04 at 17:09 +0000, jmr wrote:
>>>>  
>>>>> Himm - works for me :( Oh well, what are your compiz settings? 
>>>>> Have you tweaked anything?
>>>>>     
>>>>
>>>> Oh who knows at this point? Probably. :-)
>>>>
>>>>  
>>>>> Mine is set as follows: System -> Preferences -> Appearance -> 
>>>>> Visual Effects - Normal
>>>>>     
>>>>
>>>> Ditto.
>>>>
>>>>  
>>>>> I also do not have accessibility enabled.
>>>>>     
>>>>
>>>> This would be our winner. :-( If I disable a11y, I no longer see the
>>>> issue.
>>>>
>>>> I wonder if this is a variant of 11217?
>>>>   
>>> Yep - looks like we are not getting some focus events propagated in 
>>> the a11y framework. I will put back this change to handle the non 
>>> a11y case at least.
>>>
>>> JR
>>>> --joanie
>>>>
>>>>   
>>>
>>> _______________________________________________
>>> pkg-discuss mailing list
>>> pkg-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>