[pkg-discuss] Code Review for 5321 package manager dependencies tab could show installation status

[Joanmarie Diggs]

On Thu, 2009-10-08 at 07:33 +0100, Padraig O'Briain wrote:
> We are aware of this problem and are discussing what the best solution
> is.
> 
> I sent out the webrev as I wanted to make sure that there were no
> traceback as with some of my previous efforts.

Understood. FWIW, I'm traceback-free.
--joanie

> Padraig
> 
> On 10/07/09 21:42, Joanmarie Diggs wrote: 
> > Does this:
> > 
> >  	entire	0.5.11 (Build 5.11-0.101)	(not installed)
> > 
> > conflict with this:
> > 
> >     $ pkg list -a entire
> >     NAME (PUBLISHER)               VERSION         STATE      UFIX
> >     entire                         0.5.11-0.124    installed  ----
> > 
> > In other words, while it's 100% correct that the above item as specified
> > is not installed, the dependency is satisfied without the need for other
> > packages to be installed. So is the "Dependencies" information intended
> > to inform me of what the selected package requires, or of what I will
> > need to install? (genuine question)
> > 
> > --joanie
> > 
> > On Wed, 2009-10-07 at 16:28 +0100, Padraig O'Briain wrote:
> >   
> > > I have respun the http://cr.opensolaris.org/~padraig/ips-5321-v7/ to
> > > display the version, build and branch information in the same way as
> > > in the General Info tab.
> > > 
> > > 
> > > Padraig
> > > 
> > > On 09/25/09 13:42, Joanmarie Diggs wrote: 
> > >     
> > > > WFM. Thanks.
> > > > --joanie
> > > > 
> > > > On Fri, 2009-09-25 at 10:51 +0100, Padraig O'Briain wrote:
> > > >   
> > > >       
> > > > > I have respun the webrev
> > > > > http://cr.opensolaris.org/~padraig/ips-5321-v6/.
> > > > > I believe that it fixes the problem Joanie identified.
> > > > > 
> > > > > Padraig
> > > > > 
> > > > > On 09/18/09 06:18, Joanmarie Diggs wrote: 
> > > > >     
> > > > >         
> > > > > > Hey Padraig.
> > > > > > 
> > > > > > I found one more traceback:
> > > > > > 
> > > > > >         Traceback (most recent call last):
> > > > > >           File "/usr/bin/packagemanager", line 3171, in __update_package_info
> > > > > >             self.__set_dependencies_text(local_info, dep_info)
> > > > > >           File "/usr/bin/packagemanager", line 2980, in __set_dependencies_text
> > > > > >             if states and states[i].state == api.PackageInfo.INSTALLED:
> > > > > >         IndexError: list index out of range
> > > > > > 
> > > > > > This one I came across when examining certain packages I have in a local
> > > > > > repo. I've not figured out exactly what triggers it. For instance,
> > > > > > having switched views to my local repo, selecting SUNWcairo does not
> > > > > > trigger the error, but for some reason selecting SUNWcairomm does.
> > > > > > 
> > > > > > $ pkg list -av SUNWcairo
> > > > > > FMRI                                                             STATE      UFIX
> > > > > > pkg://mynga/SUNWcairo@1.8.8,5.11-0.122:20090916T051212Z          known      ----
> > > > > > pkg://opensolaris.org/SUNWcairo@0.5.11,5.11-0.122:20090828T200631Z installed  u---
> > > > > > 
> > > > > > $ pkg list -av SUNWcairomm
> > > > > > FMRI                                                             STATE      UFIX
> > > > > > pkg://mynga/SUNWcairomm@1.8.2,5.11-0.122:20090916T055116Z        known      ----
> > > > > > pkg://opensolaris.org/SUNWcairomm@0.5.11,5.11-0.122:20090828T200634Z installed  u---
> > > > > > 
> > > > > > <shrugs>
> > > > > > 
> > > > > > --joanie
> > > > > > 
> > > > > > On Thu, 2009-09-17 at 23:16 -0400, Joanmarie Diggs wrote:
> > > > > >   
> > > > > >       
> > > > > >           
> > > > > > > Hey Padraig.
> > > > > > > 
> > > > > > > First, I must say that the new layout is awesome. Makes it much easier
> > > > > > > to understand what's present and absent.
> > > > > > > 
> > > > > > > I did find an occurrence where things seem to fail, however. When I
> > > > > > > select a locale for OpenOffice (e.g. openoffice-hu), I get the following
> > > > > > > traceback:
> > > > > > > 
> > > > > > > Traceback (most recent call last):
> > > > > > >   File "/usr/bin/packagemanager", line 3171, in __update_package_info
> > > > > > >     self.__set_dependencies_text(local_info, dep_info)
> > > > > > >   File "/usr/bin/packagemanager", line 2950, in __set_dependencies_text
> > > > > > >     if dep_info != None or len(dep_info.get(0)) >= 0:
> > > > > > > AttributeError: 'NoneType' object has no attribute 'get'
> > > > > > > 
> > > > > > > --joanie
> > > > > > > 
> > > > > > > On Thu, 2009-09-17 at 10:39 +0100, Padraig O'Briain wrote:
> > > > > > >     
> > > > > > >         
> > > > > > >             
> > > > > > > > The webrev, http://cr.opensolaris.org/~padraig/ips-5321-v4/, fixes
> > > > > > > > 5321 package manager dependencies tab could show installation status
> > > > > > > > 
> > > > > > > > This webrev changes the layout of the dependencies panel to separate the 
> > > > > > > > package name and version and list whether it is installed or not installed.
> > > > > > > > 
> > > > > > > > Padraig
> > > > > > > > _______________________________________________
> > > > > > > > pkg-discuss mailing list
> > > > > > > > pkg-discuss at opensolaris.org
> > > > > > > > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
> > > > > > > >       
> > > > > > > >           
> > > > > > > >               
> > 
> > 
> >