[pkg-discuss] Code review: 11669 Enhance handling of Search All Publishers to match current UI Spec

[Padraig O'Briain]

Looks good to me.

Padraig

On 10/09/09 11:14, jmr wrote:
> Padraig new webrev, only changes are a few line length pylint cleanups 
> and the name change:
>
> < -                        column = gtk.TreeViewColumn(_('Repository'),
> < +                        column = gtk.TreeViewColumn(_('Publisher'),
>
> webrev: 
> http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_09Oct_1110am/
> bug: 11669 Enhance handling of Search All Publishers to match current 
> UI Spec
> bug: 11699 Missing focus rectangle and missing a11y events on PM start 
> page
>
> JR
>
>
> John Rice wrote:
>> Thanks Padraig, comments below:
>>
>> Padraig O'Briain wrote:
>>> How do I exercise the code in __handle_link with handle_what == 
>>> DISPLAY_LINK?
>> When you mouse over links in the GtkHTML widget __handle_link(... 
>> handle_what = DISPLAY_LINK) is triggered.
>>>
>>> Should moving focus between links change what is displayed in the 
>>> status bar?
>> Good question, will look into it, I don't think so, the GtkHTML 
>> widget is very limited in what it supports.
>>>
>>> The additional header after searching all publishers is 
>>> 'Repository'. Should this be 'Publisher'?
>> Yes think this should now be Publisher, will change it as part of 
>> this webrev.
>>
>> JR
>>>
>>> Padraig
>>>
>>> On 10/08/09 17:07, jmr wrote:
>>>> Michal - thanks for the feedback, I've fixed the issues below and 
>>>> also added handling when View filter hides all search results. The 
>>>> user is now warned and given a link to change the View: to All 
>>>> Packages on the page. I've incorporated various changes from 
>>>> several reviews with Padraig as well.
>>>>
>>>> webrev: 
>>>> http://cr.opensolaris.org/~jmr/pm_enhance_search_ui_11669_08Oct_5pm/
>>>> bug: 11669 Enhance handling of Search All Publishers to match 
>>>> current UI Spec
>>>> bug: 11699 Missing focus rectangle and missing a11y events on PM 
>>>> start page
>>>>
>>>> JR
>>>>
>>>> Michal Pryc wrote:
>>>>> John,
>>>>> It's working pretty well. I found two minor bugs and I will let 
>>>>> you decide what to do with them.
>>>>>
>>>>> BUG 1:
>>>>> Search for *&
>>>>> > GtkWarning: Failed to set text from markup due to error parsing 
>>>>> markup: Error on line 1: Entity did not end with a semicolon; most 
>>>>> likely you used an ampersand character without intending to start 
>>>>> an entity - escape ampersand as &amp;
>>>>> - the status bar markup is broken, probably we need to replace all 
>>>>> & to &amp; when updating statusbar.
>>>>>
>>>> Escape search string now so this is handled correctly.
>>>>> BUG 2:
>>>>> Enter space and click on magnifier search icon
>>>>> > The list of packages is empty, status bar tells that 0 results 
>>>>> were found
>>>>> - expected - nice html page should be in place, exactly like other 
>>>>> 0 results found case
>>>>> - or... do nothing when there are only spaces
>>>> Searching for spaces, just ignore and set the search field to null 
>>>> again.
>>>>>
>>>>> Michal
>>>>>
>>>>
>>
>>
>