[tesla-dev] powertop: aggregate wakeups
Li, Aubrey
aubrey.li at intel.com
Tue May 20 18:51:43 PDT 2008
Rafael Vanoni wrote:
> Aubrey Li wrote:
>> 2008/5/19 Rafael Vanoni <Rafael.Vanoni at sun.com>:
>>> I've added xcalls to the event report and the number of wakeups x
>>> events are more cohesive. This diff takes a shot at reporting that,
>>> let me know what you think.
>>>
>>> A related problem is the number of xcalls that libdtrace is
>>> generating, which puts powertop higher in the xcalls report than
>>> we'd like. I've been looking at this and emailed dtrace-discuss
>>> about it.
>>>
>> Just said on dtrace-discuss, you can use the dtrace stack() to find
>> the root cause.
>>
>> Yes, xcall is an event powertop should report, currently xcall
>> dtrace probe doesn't take the function as an argument, that prevents
>> us getting the caller easily. Is it possible to change the current
>> probe?
>>
>> execname may be acceptable, but we should exclude execname=powertop,
>> what do you think?
>>
>
>
> Here's a patch for these changes.
>
> thanks
> Rafael
Looks good to me, please feel free to commit into repo.
Thanks,
-Aubrey
More information about the tesla-dev
mailing list