[tesla-dev] [powertop bug] too many blank lines between processor state and event report
Rafael Vanoni
Rafael.Vanoni at Sun.COM
Wed May 21 06:44:57 PDT 2008
Li, Aubrey wrote:
> Rafael Vanoni wrote:
>
>> Here's a patch for this one, basically raising the event report
>> according to the number of P/C states.
>>
>> Let me know what you think.
>>
>
> moving subwindows is not a good idea, it caused segment fault sometimes
> on my side. "man mvwin" told me moving subwindows is allowed, but should
> be avoided.
>
> we may setup window after we get ncstates and npstates, so that we can
> dynamically position the event report window based on the numbers.
>
> Does it make sense?
>
> Thanks,
> -Aubrey
The only safe way I see of doing this is to set a define for the number
of C state transitions we currently support. Which is hacky :|
I think the problem here is that we're allocating blank lines according
to the number of known states, regardless of how many the system/OS
actually supports. Without the kstat c-state info, I don't see a good
way of fixing this bug besides hand coding.
Any ideas ?
thanks
Rafael
More information about the tesla-dev
mailing list