[webstack-discuss] [sfwnv-discuss] Squid 2.6 integration into SXDE review request

[rahul]

Hi,

Updated http://cr.opensolaris.org/~vrthra/squid/

| 1. a lot of the files have incorrect copyright
| messages
|    (year and format). Also are the 'ident' lines
|    correct

These are corrected now.

| 2. should the DESC= lines in the pkginfo.tmpl files 
|    have the pkg's version at the end of them?

Updated them with versions.

| 3. Should the -DSOLARIS_11 in cmd/squid/Makefile.sfw
|    be derived (from build system) rather than hard
|    coded.

While I can fetch the info from SFWRELEASE variable, I
am not sure this is the right approach. What the squid
developer intended is to check for compatibility (or
rather the presence of gssapi_generic.h), while it would
have been better to call it #ifdef HAVE_GENERIC_GSSAPI
rather than #ifdef SOLARIS_11, it is not under our control.

so if I fetch the value from the build, and solaris version
advances in a much later release, it would break the build.